Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f-aws_instance: support for launch time #37002

Merged
merged 5 commits into from
May 10, 2024
Merged

f-aws_instance: support for launch time #37002

merged 5 commits into from
May 10, 2024

Conversation

nikhil-goenka
Copy link
Contributor

Description

Relations

Closes #36977

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 19, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2024
@johnsonaj johnsonaj self-assigned this May 10, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
johnsonaj
johnsonaj approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc TESTARGS="-run=TestAccEC2InstanceDataSource" PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2InstanceDataSource -timeout 360m
--- PASS: TestAccEC2InstanceDataSource_gp2IopsDevice (57.84s)
--- PASS: TestAccEC2InstanceDataSource_blockDevices (68.00s)
--- PASS: TestAccEC2InstanceDataSource_RootBlockDevice_kmsKeyID (74.73s)
--- PASS: TestAccEC2InstanceDataSource_gp3ThroughputDevice (78.19s)
--- PASS: TestAccEC2InstanceDataSource_timeout (106.32s)
--- PASS: TestAccEC2InstanceDataSource_azUserData (106.69s)
--- PASS: TestAccEC2InstanceDataSource_EBSBlockDevice_kmsKeyID (110.15s)
--- PASS: TestAccEC2InstanceDataSource_disableAPIStopTermination (122.03s)
--- PASS: TestAccEC2InstanceDataSource_ipv6Addresses (122.49s)
--- PASS: TestAccEC2InstanceDataSource_autoRecovery (130.97s)
--- PASS: TestAccEC2InstanceDataSource_GetUserData_noUserData (153.10s)
--- PASS: TestAccEC2InstanceDataSource_getUserData (153.11s)
--- PASS: TestAccEC2InstanceDataSource_creditSpecification (93.03s)
--- PASS: TestAccEC2InstanceDataSource_securityGroups (80.75s)
--- PASS: TestAccEC2InstanceDataSource_vpcSecurityGroups (114.78s)
--- PASS: TestAccEC2InstanceDataSource_tags (208.95s)
--- PASS: TestAccEC2InstanceDataSource_basic (219.73s)
--- PASS: TestAccEC2InstanceDataSource_privateIP (102.72s)
--- PASS: TestAccEC2InstanceDataSource_vpc (225.05s)
--- PASS: TestAccEC2InstanceDataSource_keyPair (225.90s)
--- PASS: TestAccEC2InstanceDataSource_secondaryPrivateIPs (133.85s)
--- PASS: TestAccEC2InstanceDataSource_GetPasswordData_falseToTrue (245.68s)
--- PASS: TestAccEC2InstanceDataSource_GetPasswordData_trueToFalse (190.44s)
--- PASS: TestAccEC2InstanceDataSource_metadataOptions (317.61s)
--- PASS: TestAccEC2InstanceDataSource_blockDeviceTags (323.13s)
--- PASS: TestAccEC2InstanceDataSource_placementGroup (337.22s)
--- PASS: TestAccEC2InstanceDataSource_enclaveOptions (317.60s)
--- PASS: TestAccEC2InstanceDataSource_rootInstanceStore (322.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	435.178s

@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit a70d665 into hashicorp:main May 10, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the f-aws_instance branch June 16, 2024 13:02
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

@johnsonaj johnsonaj

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add launchTime to aws_instance data source
3 participants
@nikhil-goenka @johnsonaj @justinretzolk